Preemptible-RCU CPU hotplugging while maintaining real-time response
09727467 ยท 2017-08-08
Assignee
Inventors
Cpc classification
G06F2212/62
PHYSICS
G06F12/0833
PHYSICS
G06F12/128
PHYSICS
International classification
G06F12/00
PHYSICS
G06F12/128
PHYSICS
G06F9/52
PHYSICS
G06F9/50
PHYSICS
G06F12/0831
PHYSICS
Abstract
A grace period detection technique for a preemptible read-copy update (RCU) implementation that uses a combining tree for quiescent state tracking. When a leaf level bitmask indicating online/offline CPUs is fully cleared due to all of its assigned CPUs going offline as a result of hotplugging operations, the bitmask state is not immediately propagated to the root level of the combining tree as in prior art RCU implementations. Instead, propagation is deferred until all tasks are removed from an associated leaf level task list tracking tasks that were preempted inside an RCU read-side critical section. Deferring bitmask propagation obviates the need to migrate the task list to the combining tree root level in order to prevent premature grace period termination. The task list can remain at the leaf level. In this way, CPU hotplugging is accommodated while avoiding excessive degradation of real-time latency stemming from the now-eliminated task list migration.
Claims
1. A hierarchical read-copy update (RCU) grace period detection method that accommodates CPU-hotplugging while avoiding degradation of real-time latency due to task list migration, comprising: providing a combining tree of two or more levels to track quiescent states, said levels including a leaf level and a root level; determining whether a condition warrants adjusting hierarchical RCU grace period detection to account for CPUs that have gone offline due to hotplugging operations; said condition being met if (1) a leaf level bitmask of said combining tree is fully cleared to indicate an offline state in which all of its assigned CPUs are offline, and (2) there are no tasks on a task list associated with said fully cleared bitmask; if said condition is met, then propagating said offline state of said leaf level bitmask up said combining tree to a root level bitmask to thereby establish an adjusted grace period detection state in which said fully cleared bitmask's assigned CPUs are ignored for purposes of grace period detection; if said condition is partially met due to said leaf level bitmask being fully cleared to indicate an offline state in which all of its assigned CPUs are offline, but there are tasks remaining on said task list associated with said fully cleared bitmask, then (3) refraining from propagating said offline state up said combining tree to said root level bitmask and (4) maintaining said associated task list at said leaf level without migration to said root level, thereby ensuring that said tasks remaining on said task list will continue to have effect for purposes of grace period detection without having to migrate said task list; and unless said condition is fully met, continuing existing grace period detection without propagating said offline state.
2. The method of claim 1, wherein said determining whether a condition warrants adjusting said hierarchical RCU grace period detection to account for CPUs that have gone offline due to a hotplugging operation is performed whenever said hotplugging operation results in said leaf level bitmask being fully cleared to indicate said offline state.
3. The method of claim 1, wherein said determining whether a condition warrants adjusting said hierarchical RCU grace period detection to account for CPUs that have gone offline due to a hotplugging operation is performed whenever a last remaining task of said task list is removed from said task list.
4. The method of claim 1, wherein locking synchronization is provided between said periodically clearing fields of said leaf level bitmask and said propagating said offline state of said leaf level bitmask up said combining tree to said root level bitmask.
5. The method of claim 1, wherein said levels of said combining tree each comprise one or more data structures, each of which maintains a bitmask, said data structures at said leaf level each further maintain a task list.
6. The method of claim 1, wherein each of said leaf level bitmasks comprises one bit for each CPU assigned said leaf level bitmask, and wherein said root level bitmask comprises one bit for each lower level bitmask assigned to said root level bitmask.
7. The method of claim 1, wherein said tasks lists each comprise a first list portion containing tasks that are blocking a current grace period and second list portion containing tasks that are blocking a next grace period.
Description
BRIEF DESCRIPTION OF THE DRAWINGS
(1) The foregoing and other features and advantages will be apparent from the following more particular description of example embodiments, as illustrated in the accompanying Drawings.
(2)
(3)
(4)
(5)
(6)
(7)
(8)
(9)
(10)
(11)
(12)
(13)
(14)
(15)
DETAILED DESCRIPTION OF EXAMPLE EMBODIMENTS
(16) Turning now to the figures, wherein like reference numerals represent like elements in all of the several views,
(17) The computer system 2 may represent any of several different types of computing apparatus. Such computing apparatus may include, but are not limited to, general purpose computers, special purpose computers, portable computing devices, communication and/or media player devices, set-top devices, embedded systems, and other types of information handling machines. The term processor as used with reference to the processors 4.sub.1, 4.sub.2 . . . 4.sub.n encompasses any program execution unit capable of executing program instructions, including but not limited to a packaged integrated circuit device (such as a microprocessor), a processing core within a packaged integrated circuit device (such as a microprocessor core), or a hardware thread comprising one or more functional units within a processing core (such as an SMT thread). Each such execution unit may also be referred to as a CPU (central processing unit). The processors 4.sub.1, 4.sub.2 . . . 4.sub.n may be situated within a single computing device or node (e.g., as part of a single-node SMP system) or they may be distributed over plural nodes (e.g., as part of a NUMA system, a cluster, or a cloud). The memory 8 may comprise any type of tangible storage medium capable of storing data in computer readable form for use in program execution, including but not limited to, any of various types of random access memory (RAM), various flavors of programmable read-only memory (PROM) (such as flash memory), and other types of primary storage (i.e., program memory). The cache memories 10.sub.1, 10.sub.2 . . . 10.sub.n may be implemented in several levels (e.g., as level 1, level 2 and level 3 caches) and the cache controllers 12.sub.1, 12.sub.2 . . . 12.sub.n may collectively represent the cache controller logic that supports each cache level. As illustrated, the memory controller 14 may reside separately from processors 4.sub.1, 4.sub.2 . . . 4.sub.n, for example, as part of a discrete chipset. Alternatively, as previously mentioned, the memory controller 14 could be provided by plural memory controller instances that are respectively integrated with the processors 4.sub.1, 4.sub.2 . . . 4.sub.n.
(18) Each CPU embodied by a given processor 4 is operable to execute program instruction logic under the control of a software program stored in the memory 8 (or elsewhere). As part of this program execution logic, update operations (updaters) 18 may execute within a process, thread, or other execution context (hereinafter task) on any of the processors 4. Each updater 18 runs periodically to perform updates on a set of shared data 16 that may be stored in the shared memory 8 (or elsewhere). In
(19) Any given processor 4 may also periodically execute a read operation (reader) 21. Each reader 21 runs from program instructions stored in the memory 8 (or elsewhere) in order to periodically perform read operations on the set of shared data 16 stored in the shared memory 8 (or elsewhere). In
(20) For purposes of the present disclosure, it is assumed that the readers 21 may be preempted while executing within their RCU read-side critical sections. This would be the case, for example, if the readers 21 embody kernel code paths in a preemptible operating system kernel. To accommodate such reader preemption, the RCU subsystem 20 is embodied as a preemptible RCU implementation.
(21) During operation of the computer system 2, an updater 18 will occasionally perform an update to one of the shared data elements 16. In accordance with the philosophy of RCU, a first-phase update may be performed in a manner that temporarily preserves a pre-update view of the shared data element for the benefit of readers 21 that may be concurrently referencing the shared data element during the update operation. Following the first-phase update, the updater 18 may invoke an RCU primitive such as synchronize_rcu( ) to invoke the RCU subsystem 20 to track a grace period for deferred destruction of the pre-update view of the data (second-phase update). The grace period processing performed by the RCU subsystem 20 entails starting new grace periods and detecting the end of old grace periods so that the RCU subsystem 20 knows when it is safe to free stale data (or take other actions).
(22) Turning now to
(23) The RCU reader API 32 may comprise a reader registration component and a reader unregistration component that are respectively invoked by readers 21 as they enter and leave their RCU read-side critical sections to read shared data 16. This allows the RCU subsystem 20 to track reader operations and determine when readers are engaged in RCU-protected read-side critical section processing. In an example embodiment, the reader registration and unregistration components may be respectively implemented using the rcu_read_lock( ) and rcu_read_unlock( ) primitives found in existing read-copy update implementations.
(24) The RCU updater API 34 may comprise a synchronization primitive such as synchronize_rcu( ) for use by updaters 18 to defer the removal of shared data 16 that may be referenced by the readers 21 until the grace period detection component 36 determines that a grace period has elapsed.
(25) The grace period detection component 36 of the RCU subsystem 20 includes various functions that participate in starting new grace periods and detecting the end of old grace periods. The grace period detection component 36 further includes an improved mechanism to facilitate improved hierarchical RCU grace period detection during CPU hotplugging, while avoiding excessive degradation of real-time latency due to task list migration. The operational details of this improved mechanism are described in more detail below.
(26) With continuing reference now to
(27) As discussed in the Background section above, the last CPU of a leaf rcu_node structure 54 can go offline while the leaf rcu_node structure's ->blkd_tasks list is non-empty. In prior art RCU implementations, the offline state of the leaf rcu_node structure's ->qsmaskinit bitmask is promptly propagated up the rcu_node tree hierarchy to the root rcu_node structure. At the same time, grace period stalling is prevented by migrating the ->blkd_tasks list of the leaf rcu_node structure to the root rcu_node structure. As indicated at the conclusion of the Background section above, the inventor named herein has observed that this strategy can result in a real-time performance penalty due to the overhead associated with the list moving operations, such as having to repeatedly release and acquire the ->locks of the leaf and root rcu_node structures as the tasks are migrated one at a time.
(28) The improved hierarchical RCU grace period detection technique disclosed herein overcomes this problem. When a leaf rcu_node structure's ->qsmaskinit bitmask is fully cleared due to all of its assigned CPUs going offline as a result of hotplugging operations, the bitmask state is not immediately propagated to the root rcu_node structure as in prior art RCU implementations. Instead, propagation is deferred until all tasks are removed from the leaf rcu_node structure's ->blkd_tasks list. Deferring bitmask propagation obviates the need to migrate the ->blkd_tasks list to the root rcu_node structure in order to prevent premature grace period termination. The ->blkd_tasks list can remain at the leaf rcu_node structure. In this way, CPU hotplugging is accommodated while avoiding excessive degradation of real-time latency stemming from the now-eliminated task list migration operation.
(29) Before describing the foregoing technique in more detail, it will be helpful to illustrate an example of the prior art grace period detection approach that uses ->blkd_tasks list migration. Turning now to
(30) In
(31) The leaf rcu_node structure 54B is shown to be tracking two tasks (designated A and B) that have been preempted while in their current RCU read-side critical sections while running on a CPU assigned to the leaf rcu_node structure 54B (i.e., CPU0 or CPU1). Both tasks are therefore members of the ->blkd_tasks list of leaf rcu_node structure 54B. The tag t in
(32) Offlining CPU 0 using the prior-art scheme would result in the state shown in
(33) The hierarchical RCU grace period detection technique proposed herein will now be described with reference to the example shown in
(34)
(35)
(36) Propagation as used herein refers to clearing ->qsmaskinit bits up the hierarchy of rcu_node structures 54 of the rcu_state structure 52, with each lower level rcu_node structure clearing its assigned bit in the higher level rcu_node structure to which it reports. In
(37) As shown in
(38) With continued reference to
(39) Turning now to
(40) Of course, it is possible that either CPU0 or CPU1 might have come online in the meantime. Had this happened, the ->qsmaskinit bitmask of the leaf rcu_node structure 54B would have been non-zero when task A exited its RCU read-side critical section. This this condition would have prevented any propagation of the ->qsmaskinit bitmask state of the leaf rcu_node structure 54B to the root rcu_node structure 54A because bitmask propagation requires that a leaf rcu_node structure's ->qsmaskinit bitmask be fully cleared. The bit in the root rcu_node structure's ->qsmaskinit bitmask that corresponds to the leaf rcu_node structure 54B would remain set, and the grace period detection function 36 would continue to track the leaf rcu_node structure 54B.
(41) Contrasting the operations of
(42) Turning now to
(43) The combining tree may have at least one bitmask at each of the levels indicating which CPU's are offline and whose quiescent states are not required to end a grace period, each leaf level bitmask having fields associated with a set of assigned CPUs, and the root level bitmask having fields associated with a set of lower level bitmasks. The combining tree may further have one or more task lists at the leaf level identifying tasks that were preempted while in an RCU read-side critical section and are blocking a grace period. Each leaf level task list is associated with a set of assigned CPUs that is also assigned to one of the leaf level bitmasks, such that each of the leaf level tasks lists is thereby associated with one of the leaf level bitmasks. In the embodiment of
(44) Periodically, the fields of the leaf level bitmasks are cleared as the CPUs assigned to those bitmasks go offline. These operations are exemplified by block 100 in
(45) Periodically, tasks are removed from the task lists as the tasks exit their RCU read-side critical sections. These operations are exemplified by block 102 in
(46) Block 104 of
(47) Block 106 exemplifies a state where the condition checked for in block 104 is not met. In that case, processing returns to the caller, and existing grace period detection is continued without adjusting the grace period detection state to account for newly offlined CPUs. Note that block 106 may be reached if neither part of the condition checked for in block 104 is satisfied. Moreover, block 106 will be reached if condition checked for in block 104 is only partially met because one of the condition's two parts remain unsatisfied.
(48) Of particular interest is the state where the condition is only partially met due to one of the leaf level bitmasks (e.g., a leaf rcu_node structure's ->qsmaskinit bitmask) being fully cleared to indicate an offline state in which all of its assigned CPUs are offline, but there are tasks remaining on the task list associated with the fully cleared bitmask (e.g., the same leaf rcu_node structure's ->blkd_tasks list). In that case, the return from processing in block 106 means that the offline state of the leaf level bitmask is not propagated up the combining tree to the root level bitmask, and the task lists are maintained at the leaf level without migration to the root level. This ensures that the tasks remaining on the task list will continue to have effect for purposes of grace period detection without having to migrate the tasks list.
(49) Block 108 exemplifies a state where the condition checked for in block 104 is met. In that case, the offline state of the leaf level bitmask (e.g., a leaf rcu_node structure's ->qsmaskinit bitmask) is propagated up the combining tree to the root level bitmask (e.g., the root rcu_node structure's ->qsmaskinit bitmask) to thereby establish an adjusted grace period detection state in which the leaf rcu_node structure and anything else associated with the fully cleared bitmask are now ignored for purposes of grace period detection.
(50) Note that locking synchronization between the CPU hotplug operation in block 100 and the propagation operation of block 108, both of which can manipulate the same leaf level bitmask (e.g., a leaf rcu_node structure's ->qsmaskinit bitmask), may be provided by a leaf level lock. If the RCU subsystem data structures 50 of
(51) Accordingly, a technique has been disclosed for use in a preemptible read-copy update (RCU) implementation to facilitate improved hierarchical RCU grace period detection during CPU hotplugging while avoiding excessive degradation of real-time latency due to task list migration. It will be appreciated that the foregoing concepts may be variously embodied in any of a data processing system, a machine implemented method, and a computer program product in which programming logic is provided by one or more computer readable data storage media for use in controlling a data processing system to perform the required functions. Example embodiments of a machine-implemented method and data processing system were previously described in connection with
(52) With respect to a computer program product, digitally encoded program instructions may be stored on one or more computer readable data storage media for use in controlling a computer or other information handling machine or device to perform the required functions. The program instructions may be embodied as machine language code that is ready for loading and execution by the machine apparatus, or the program instructions may comprise a higher level language that can be assembled, compiled or interpreted into machine language. Example languages include, but are not limited to C, C++, assembly, to name but a few. When implemented on a machine comprising a processor, the program instructions combine with the processor to provide a particular machine that operates analogously to specific logic circuits, which themselves could be used to implement the disclosed subject matter.
(53) Example computer readable data storage media for storing such program instructions are shown by reference numerals 8 (memory) and 10 (cache) of the computer system 2 of
(54) The computer readable storage medium can thus be a tangible device that can retain and store instructions for use by an instruction execution device. The computer readable storage medium may be, for example, but is not limited to, an electronic storage device, a magnetic storage device, an optical storage device, an electromagnetic storage device, a semiconductor storage device, or any suitable combination of the foregoing. A non-exhaustive list of more specific examples of the computer readable storage medium includes the following: a portable computer diskette, a hard disk, a random access memory (RAM), a read-only memory (ROM), an erasable programmable read-only memory (EPROM or Flash memory), a static random access memory (SRAM), a portable compact disc read-only memory (CD-ROM), a digital versatile disk (DVD), a memory stick, a floppy disk, a mechanically encoded device such as punch-cards or raised structures in a groove having instructions recorded thereon, and any suitable combination of the foregoing. A computer readable storage medium, as used herein, is not to be construed as being transitory signals per se, such as radio waves or other freely propagating electromagnetic waves, electromagnetic waves propagating through a waveguide or other transmission media (e.g., light pulses passing through a fiber-optic cable), or electrical signals transmitted through a wire.
(55) Computer readable program code described herein can be downloaded to respective computing/processing devices from a computer readable storage medium or to an external computer or external storage device via a network, for example, the Internet, a local area network, a wide area network and/or a wireless network. The network may include copper transmission cables, optical transmission fibers, wireless transmission, routers, firewalls, switches, gateway computers and/or edge servers. A network adapter card or network interface in each computing/processing device receives computer readable program code from the network and forwards the computer readable program code for storage in a computer readable storage medium within the respective computing/processing device.
(56) Computer readable program code for carrying out operations of the present invention may be assembler instructions, instruction-set-architecture (ISA) instructions, machine instructions, machine dependent instructions, microcode, firmware instructions, state-setting data, or either source code or object code written in any combination of one or more programming languages, including an object oriented programming language such as Smalltalk, C++ or the like, and conventional procedural programming languages, such as the C programming language or similar programming languages. The computer readable program code may execute entirely on the user's computer, partly on the user's computer, as a stand-alone software package, partly on the user's computer and partly on a remote computer or entirely on the remote computer or server. In the latter scenario, the remote computer may be connected to the user's computer through any type of network, including a local area network (LAN) or a wide area network (WAN), or the connection may be made to an external computer (for example, through the Internet using an Internet Service Provider). As previously mentioned, in some embodiments, electronic circuitry including, for example, programmable logic circuitry, field-programmable gate arrays (FPGA), or programmable logic arrays (PLA) may execute the computer readable program code by utilizing state information of the computer readable program code to personalize the electronic circuitry, in order to perform aspects of the present invention.
(57) Aspects of the present invention are described herein with reference to flowchart illustrations and/or block diagrams of methods, apparatus (systems), and computer program products according to embodiments of the invention. It will be understood that each block of the flowchart illustrations and/or block diagrams, and combinations of blocks in the flowchart illustrations and/or block diagrams, can be implemented by computer readable program code.
(58) The computer readable program code may be provided to a processor of a general purpose computer, special purpose computer, or other programmable data processing apparatus to produce a machine, such that the instructions, which execute via the processor of the computer or other programmable data processing apparatus, create means for implementing the functions/acts specified in the flowchart and/or block diagram block or blocks. These computer readable program code may also be stored in a computer readable storage medium that can direct a computer, a programmable data processing apparatus, and/or other devices to function in a particular manner, such that the computer readable storage medium having instructions stored therein includes an article of manufacture including instructions which implement aspects of the function/act specified in the flowchart and/or block diagram block or blocks.
(59) The computer readable program code may also be loaded onto a computer, other programmable data processing apparatus, or other device to cause a series of operational steps to be performed on the computer, other programmable apparatus or other device to produce a computer implemented process, such that the instructions which execute on the computer, other programmable apparatus, or other device implement the functions/acts specified in the flowchart and/or block diagram block or blocks.
(60) The flowchart and block diagrams in the Figures illustrate the architecture, functionality, and operation of possible implementations of systems, methods, and computer program products according to various embodiments of the present invention. In this regard, each block in the flowchart or block diagrams may represent a module, segment, or portion of instructions, which includes one or more executable instructions for implementing the specified logical function(s). In some alternative implementations, the functions noted in the block may occur out of the order noted in the figures. For example, two blocks shown in succession may, in fact, be executed substantially concurrently, or the blocks may sometimes be executed in the reverse order, depending upon the functionality involved. It will also be noted that each block of the block diagrams and/or flowchart illustration, and combinations of blocks in the block diagrams and/or flowchart illustration, can be implemented by special purpose hardware-based systems that perform the specified functions or acts or carry out combinations of special purpose hardware and computer instructions.
(61) Although various example embodiments have been shown and described, it should be apparent that many variations and alternative embodiments could be implemented in accordance with the disclosure. It is understood, therefore, that the invention is not to be in any way limited except in accordance with the spirit of the appended claims and their equivalents.